Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dedicated block cache for blob transactions #7032

Merged
merged 1 commit into from
May 16, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 16, 2024

  • Seems to be that the block cache size fluctuate.
  • Seems to map with the blob transactions index.
  • This set a dedicated block cache for blob transactions so that it does not effect the shared block cache which is used by state.
  • The effect of the shared block cache on the block processing is was shown to be not much at all before as the file get os-cached in the first place. There could be a minor difference though.

Screenshot from 2024-05-16 16-25-40

Changes

  • Set dedicated block cache for blob transaction.

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Manual log shows dedicated cache is used.

@asdacap asdacap marked this pull request as ready for review May 16, 2024 08:48
@asdacap asdacap requested a review from rubo as a code owner May 16, 2024 08:48
@asdacap asdacap merged commit f6aeae0 into master May 16, 2024
67 checks passed
@asdacap asdacap deleted the perf/set-dedicated-block-cache-for-blobs branch May 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants