Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayPool for Kzg.AreProofsValid #7016

Merged
merged 1 commit into from
May 14, 2024
Merged

Use ArrayPool for Kzg.AreProofsValid #7016

merged 1 commit into from
May 14, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 13, 2024 •
edited
Loading

Changes

  • Use ArrayPool<byte>.Shared rather than allocating new arrays for AreProofsValid

Is a mild allocator

image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from flcl42 May 13, 2024 18:58
@benaadams benaadams marked this pull request as ready for review May 13, 2024 19:05
@benaadams benaadams merged commit d392589 into master May 14, 2024
67 checks passed
@benaadams benaadams deleted the kzg branch May 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej