Less allocations for node processing #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
May 2, 2024
src/Nethermind/Nethermind.Network.Discovery/RoutingTable/NodeTable.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network.Discovery/RoutingTable/NodeBucket.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
May 2, 2024
Comment on lines
+136
to
+143
| if (count < _capacity / 2) | ||
| { | ||
| // Reduced to less than half of the capacity, resize the array. | ||
| T[] newArray = _arrayPool.Rent(count); | ||
| _array.AsSpan(0, count).CopyTo(newArray); | ||
| T[] oldArray = Interlocked.Exchange(ref _array, newArray); | ||
| _capacity = newArray.Length; | ||
| _arrayPool.Return(oldArray); |
There was a problem hiding this comment.
Is it worth it, to potentially copy over this data to the new buffer?
I expect this data to be consumed fairly quickly and the whole buffer would return.
IMO probably not worth it at
There was a problem hiding this comment.
The consumers only want 12 or 16 elements by default; so copy isn't that big, but can be hundreds or thousands of nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses the following allocations
Types of changes
What types of changes does your code introduce?
Testing
Requires testing