Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tracer name empty exception #6915

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix tracer name empty exception #6915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c77d18
fix tracer name empty exception
FatTigerWang Apr 12, 2024
cb912cf
Merge branch 'master' into fix-rpc-debug_traceTransaction-tracer-exce…
LukaszRozmej Apr 15, 2024
129925f
Merge branch 'master' into fix-rpc-debug_traceTransaction-tracer-exce…
LukaszRozmej Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Nethermind/Nethermind.Evm.Test/Tracing/GethLikeNativeTracerFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,20 @@ public void IsNativeTracer_TracerNameDoesNotExist()

Assert.False(isNativeTracer);
}

[Test]
public void CreateTracer_TracerNameIsEmpty()
{
var isNativeTracer = GethLikeNativeTracerFactory.IsNativeTracer(string.Empty);

Assert.False(isNativeTracer);
}

[Test]
public void CreateTracer_TracerNameIsNull()
{
var isNativeTracer = GethLikeNativeTracerFactory.IsNativeTracer(null);

Assert.False(isNativeTracer);
}
}
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Evm/Tracing/GethStyle/Custom/Native/GethLikeNativeTracerFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static GethLikeNativeTxTracer CreateTracer(GethTraceOptions options) =>

public static bool IsNativeTracer(string tracerName)
{
return _tracers.ContainsKey(tracerName);
return !string.IsNullOrWhiteSpace(tracerName) && _tracers.ContainsKey(tracerName);
}

private static void RegisterNativeTracers()
Expand Down
Loading