-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update txPool worst value if removal unsuccessful #6702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please wait for @marcindsobczak review too.
marcindsobczak
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kamilchodola
pushed a commit
that referenced
this pull request
Feb 13, 2024
kamilchodola
added a commit
that referenced
this pull request
Feb 16, 2024
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola
added a commit
that referenced
this pull request
Feb 23, 2024
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola
added a commit
that referenced
this pull request
Feb 26, 2024
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h
pushed a commit
to fuseio/nethermind-client
that referenced
this pull request
Jun 25, 2024
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h
pushed a commit
to fuseio/nethermind-client
that referenced
this pull request
Jun 25, 2024
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
gr8h
pushed a commit
to fuseio/nethermind-client
that referenced
this pull request
Jun 25, 2024
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com> Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6557
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing