Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise PPA packaging #6618

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Revise PPA packaging #6618

merged 2 commits into from
Jan 25, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jan 25, 2024

Fixes #5192 #4703 #4347

Changes

  • Revised Debian package scripts to use the same logic as winget and homebrew
  • Fixed package version to be the same as Nethermind's one (e.g., 1.25.3 instead of 1.2530)
  • Fixed install/uninstall scripts not to remove sync data

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Ubuntu packaging

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tested manually. Successfully published on PPA.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

The PPA package version has been fixed, and installation scripts are revised not to remove sync data, if any.
Hence, to install the new fixed version, first uninstall the existing package as follows:

apt-get purge nethermind
apt-get update

Please make sure your sync data is backed up, if any.

@rubo rubo requested review from stdevMac and kamilchodola January 25, 2024 19:55
@rubo rubo requested a review from a team as a code owner January 25, 2024 19:55
@rubo rubo merged commit b3453bf into master Jan 25, 2024
67 checks passed
@rubo rubo deleted the fix/ppa-refactor branch January 25, 2024 22:05
marcindsobczak pushed a commit that referenced this pull request Feb 2, 2024
(cherry picked from commit b3453bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PPA installer removes existing data on package update
2 participants