Wait for blob inclusion #6090
Closed
Wait for blob inclusion #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sDataGas mismatch.
* Blob gas info in receipts * Fix gas price * Fix spaces * Add tests * Supports blobs * Ignore on null * Fix suggestions * Fix build --------- Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com>
flcl42
reviewed
Sep 15, 2023
This reverts commit 0142329. undo maxPriorityFeePerGas
Also follows gas strategy from tx-fuzz https://github.com/MariusVanDerWijden/tx-fuzz/blob/master/cmd/4844/main.go#L65C19-L65C34
Command line parsing of all args. Commands for distributing funds and also reclaiming all distributed funds again.
Use keyfile as args to make every blob tx use a different private key in round robin style.
MarekM25
requested changes
Sep 26, 2023
This reverts commit 1a3c7b4.
flcl42
approved these changes
Oct 2, 2023
tools/SendBlobs/README.md
Outdated
| 5 = 1st blob's wrong commitment | ||
| 6 = 1st blob with a modulo correct, but > modulo value | ||
| 7 = max fee per blob gas = max value | ||
| 8 = max fee per blob gas > max value |
There was a problem hiding this comment.
Could you remove this mention and above in the code as it's was removed after TxDecoder rollback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Send blobs tool now includes: