Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of chainspec tests & handle chainspec exceptions #5819

Merged
merged 13 commits into from
Jun 15, 2023
Merged

Refactoring of chainspec tests & handle chainspec exceptions #5819

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
80ab783
Working on GnosisSpecProvider
MarekM25 Jun 5, 2023
652d09c
Passed test
MarekM25 Jun 5, 2023
e331b14
More GetSpec checks
MarekM25 Jun 5, 2023
deaf1f8
Working on gnosis exceptions
MarekM25 Jun 5, 2023
919f991
handle gnosis exceptions
MarekM25 Jun 15, 2023
3e5c817
cosmetic
MarekM25 Jun 13, 2023
93f5d97
refactoring chainspec loading
MarekM25 Jun 15, 2023
7de083a
resolved conflicts
MarekM25 Jun 15, 2023
f445586
chainspec tests refactoring
MarekM25 Jun 15, 2023
9e9501b
chainspec tests refactoring
MarekM25 Jun 15, 2023
01987a3
whitespace fix
MarekM25 Jun 15, 2023
b7bc709
fix test
MarekM25 Jun 15, 2023
d392c46
whitespace
MarekM25 Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 55 additions & 31 deletions src/Nethermind/Nethermind.Specs.Test/ChainSpecStyle/ChainSpecBasedSpecProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,7 @@ public void Logs_warning_when_timestampActivation_happens_before_blockActivation
[Test]
public void Sepolia_loads_properly()
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/sepolia.json");
ChainSpec chainSpec = loader.Load(File.ReadAllText(path));
chainSpec.Parameters.Eip2537Transition.Should().BeNull();

ChainSpec chainSpec = LoadChainSpecFromChainFolder("sepolia");
ChainSpecBasedSpecProvider provider = new(chainSpec);
SepoliaSpecProvider sepolia = SepoliaSpecProvider.Instance;

Expand Down Expand Up @@ -179,11 +175,7 @@ public void Rinkeby_loads_properly()
[Test]
public void Goerli_loads_properly()
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/goerli.json");
ChainSpec chainSpec = loader.Load(File.ReadAllText(path));
chainSpec.Parameters.Eip2537Transition.Should().BeNull();

ChainSpec chainSpec = LoadChainSpecFromChainFolder("goerli");
ChainSpecBasedSpecProvider provider = new(chainSpec);
GoerliSpecProvider goerli = GoerliSpecProvider.Instance;

Expand Down Expand Up @@ -214,17 +206,14 @@ public void Goerli_loads_properly()
[Test]
public void Chiado_loads_properly()
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/chiado.json");
ChainSpec chainSpec = loader.Load(File.ReadAllText(path));

ChainSpec chainSpec = LoadChainSpecFromChainFolder("chiado");
ChainSpecBasedSpecProvider provider = new(chainSpec);
ChiadoSpecProvider chiado = ChiadoSpecProvider.Instance;

List<ForkActivation> forkActivationsToTest = new()
{
(ForkActivation)0,
//(ForkActivation)1,
(ForkActivation)(1, 20),
(1, ChiadoSpecProvider.ShanghaiTimestamp - 1),
(1, ChiadoSpecProvider.ShanghaiTimestamp),
(999_999_999, 999_999_999) // far in the future
Expand All @@ -235,21 +224,18 @@ public void Chiado_loads_properly()
Assert.That(provider.ChainId, Is.EqualTo(BlockchainIds.Chiado));
Assert.That(provider.NetworkId, Is.EqualTo(BlockchainIds.Chiado));

provider.GetSpec((1, ChiadoSpecProvider.ShanghaiTimestamp - 1)).MaxCodeSize.Should().Be(long.MaxValue);
provider.GetSpec((1, ChiadoSpecProvider.ShanghaiTimestamp)).MaxCodeSize.Should().Be(24576L);
provider.GetSpec((1, ChiadoSpecProvider.ShanghaiTimestamp)).MaxInitCodeSize.Should().Be(2 * 24576L);
IReleaseSpec? preShanghaiSpec = provider.GetSpec((1, ChiadoSpecProvider.ShanghaiTimestamp - 1));
IReleaseSpec? postShanghaiSpec = provider.GetSpec((1, ChiadoSpecProvider.ShanghaiTimestamp));

VerifyGnosisShanghaiExceptions(preShanghaiSpec, postShanghaiSpec);
GetTransitionTimestamps(chainSpec.Parameters).Should().AllSatisfy(
t => ValidateSlotByTimestamp(t, ChiadoSpecProvider.BeaconChainGenesisTimestamp, GnosisBlockTime).Should().BeTrue());
}

[Test]
public void Gnosis_loads_properly()
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/gnosis.json");
ChainSpec chainSpec = loader.Load(File.ReadAllText(path));

ChainSpec chainSpec = LoadChainSpecFromChainFolder("gnosis");
ChainSpecBasedSpecProvider provider = new(chainSpec);
GnosisSpecProvider gnosisSpecProvider = GnosisSpecProvider.Instance;

Expand Down Expand Up @@ -277,22 +263,52 @@ public void Gnosis_loads_properly()
Assert.That(provider.ChainId, Is.EqualTo(BlockchainIds.Gnosis));
Assert.That(provider.NetworkId, Is.EqualTo(BlockchainIds.Gnosis));

provider.GetSpec((1, GnosisSpecProvider.ShanghaiTimestamp - 1)).MaxCodeSize.Should().Be(long.MaxValue);
VerifyGnosisPreShanghaiExceptions(provider);

/* ToDo uncomment with Gnosis fork specified
IReleaseSpec? preShanghaiSpec = provider.GetSpec((GnosisSpecProvider.LondonBlockNumber + 1,
GnosisSpecProvider.ShanghaiTimestamp - 1));
IReleaseSpec? postShanghaiSpec = provider.GetSpec((GnosisSpecProvider.LondonBlockNumber + 1,
GnosisSpecProvider.ShanghaiTimestamp));

/* ToDo uncomment when we have gnosis shapella timestamp
provider.GetSpec((1, GnosisSpecProvider.ShanghaiTimestamp)).MaxCodeSize.Should().Be(24576L);
provider.GetSpec((1, GnosisSpecProvider.ShanghaiTimestamp)).MaxInitCodeSize.Should().Be(2 * 24576L);*/
VerifyGnosisPreShanghaiExceptions(preShanghaiSpec, postShanghaiSpec);
GetTransitionTimestamps(chainSpec.Parameters).Should().AllSatisfy(
t => ValidateSlotByTimestamp(t, GnosisSpecProvider.BeaconChainGenesisTimestamp, GnosisBlockTime).Should().BeTrue()); */
}

private void VerifyGnosisShanghaiExceptions(IReleaseSpec preShanghaiSpec, IReleaseSpec postShanghaiSpec)
{
preShanghaiSpec.MaxCodeSize.Should().Be(long.MaxValue);
postShanghaiSpec.MaxCodeSize.Should().Be(24576L);

preShanghaiSpec.MaxInitCodeSize.Should().Be(-2L); // doesn't have meaningful value before EIP3860
postShanghaiSpec.MaxInitCodeSize.Should().Be(2 * 24576L);

preShanghaiSpec.LimitCodeSize.Should().Be(false);
postShanghaiSpec.LimitCodeSize.Should().Be(true);

preShanghaiSpec.IsEip170Enabled.Should().Be(false);
postShanghaiSpec.IsEip170Enabled.Should().Be(true);
}

private void VerifyGnosisPreShanghaiExceptions(ISpecProvider specProvider)
{
specProvider.GenesisSpec.MaximumUncleCount.Should().Be(0);
specProvider.GetSpec((ForkActivation)(GnosisSpecProvider.ConstantinopoleBlockNumber - (1))).IsEip1283Enabled.Should()
.BeFalse();
specProvider.GetSpec((ForkActivation)GnosisSpecProvider.ConstantinopoleBlockNumber).IsEip1283Enabled.Should()
.BeTrue();
specProvider.GetSpec((ForkActivation)(GnosisSpecProvider.ConstantinopoleBlockNumber - 1)).UseConstantinopleNetGasMetering.Should()
.BeFalse();
specProvider.GetSpec((ForkActivation)GnosisSpecProvider.ConstantinopoleBlockNumber).UseConstantinopleNetGasMetering.Should()
.BeTrue();
}


[Test]
public void Mainnet_loads_properly()
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/foundation.json");
ChainSpec chainSpec = loader.Load(File.ReadAllText(path));
chainSpec.Parameters.Eip2537Transition.Should().BeNull();

ChainSpec chainSpec = LoadChainSpecFromChainFolder("foundation");
ChainSpecBasedSpecProvider provider = new(chainSpec);
MainnetSpecProvider mainnet = MainnetSpecProvider.Instance;

Expand Down Expand Up @@ -332,6 +348,7 @@ public void Mainnet_loads_properly()
provider.GetSpec((MainnetSpecProvider.SpuriousDragonBlockNumber, null)).MaxCodeSize.Should().Be(24576L);
provider.GetSpec((MainnetSpecProvider.SpuriousDragonBlockNumber, null)).MaxInitCodeSize.Should().Be(2 * 24576L);

provider.GetSpec((ForkActivation)(long.MaxValue - 1)).IsEip2537Enabled.Should().BeFalse();
Assert.That(provider.GenesisSpec.Eip1559TransitionBlock, Is.EqualTo(MainnetSpecProvider.LondonBlockNumber));
Assert.That(provider.GetSpec((ForkActivation)4_369_999).DifficultyBombDelay, Is.EqualTo(0_000_000));
Assert.That(provider.GetSpec((ForkActivation)4_370_000).DifficultyBombDelay, Is.EqualTo(3_000_000));
Expand Down Expand Up @@ -460,6 +477,13 @@ public void Ropsten_loads_properly()
Assert.That(provider.GenesisSpec.Eip1559TransitionBlock, Is.EqualTo(RopstenSpecProvider.LondonBlockNumber));
}

private ChainSpec LoadChainSpecFromChainFolder(string chain)
{
ChainSpecLoader loader = new(new EthereumJsonSerializer());
string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, $"../../../../Chains/{chain}.json");
return loader.Load(File.ReadAllText(path));
}

[Test]
public void Chain_id_is_set_correctly()
{
Expand Down