Added GnosisSpecProvider and gnosis_loads_properly test #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jun 5, 2023
Comment on lines
+238
to
+240
| ChainSpecLoader loader = new(new EthereumJsonSerializer()); | ||
| string path = Path.Combine(TestContext.CurrentContext.WorkDirectory, "../../../../Chains/gnosis.json"); | ||
| ChainSpec chainSpec = loader.Load(File.ReadAllText(path)); |
There was a problem hiding this comment.
This is used all over those test would be good to make it a method.
There was a problem hiding this comment.
agreed, will do in next PR
Comment on lines
+245
to
+262
| List<ForkActivation> forkActivationsToTest = new() | ||
| { | ||
| (ForkActivation)0, | ||
| (ForkActivation)1, | ||
| (ForkActivation)(GnosisSpecProvider.ConstantinopoleBlockNumber -1), | ||
| (ForkActivation)(GnosisSpecProvider.ConstantinopoleBlockNumber), | ||
| (ForkActivation)(GnosisSpecProvider.ConstantinopoleFixBlockNumber -1), | ||
| (ForkActivation)(GnosisSpecProvider.ConstantinopoleFixBlockNumber), | ||
| (ForkActivation)(GnosisSpecProvider.IstanbulBlockNumber -1), | ||
| (ForkActivation)(GnosisSpecProvider.IstanbulBlockNumber), | ||
| (ForkActivation)(GnosisSpecProvider.BerlinBlockNumber -1), | ||
| (ForkActivation)(GnosisSpecProvider.BerlinBlockNumber), | ||
| (ForkActivation)(GnosisSpecProvider.LondonBlockNumber -1), | ||
| (ForkActivation)(GnosisSpecProvider.LondonBlockNumber), | ||
| (1, GnosisSpecProvider.ShanghaiTimestamp - 1), | ||
| (1, GnosisSpecProvider.ShanghaiTimestamp), | ||
| (999_999_999, 999_999_999) // far in the future | ||
| }; |
There was a problem hiding this comment.
yeah, it might be a bit harder though. Of course, doable ;)
smartprogrammer93
approved these changes
Jun 5, 2023
kamilchodola
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Working on GnosisSpecProvider * Passed test * More GetSpec checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing