Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WriteBytesPerSec to BytesPerSec and add direct io flag. #5641

Merged
merged 3 commits into from
May 3, 2023
Merged

Rename WriteBytesPerSec to BytesPerSec and add direct io flag. #5641

merged 3 commits into from
May 3, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 2, 2023 •
edited
Loading

  • Ratelimiter is also used for compaction reads and reads with custom priority. So write bytes per sec is actually wrong.
  • Add direct io flags. Direct io bypass the OS's block cache. Tend to help with memory pressure, althought its unclear if its because its slower.

Changes

  • Rename param.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@asdacap asdacap added the minor label May 2, 2023
@asdacap asdacap changed the title Rename WriteBytesPerSec to BytesPerSec Rename WriteBytesPerSec to BytesPerSec and add direct io flag. May 2, 2023
@asdacap asdacap merged commit f6b1fa2 into master May 3, 2023
@asdacap asdacap deleted the refactor/rename-write-rates branch May 3, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @benaadams