Bugfix/autorepair fix invalid best state calculation #5617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retake snapshot add warning fix tests
MarekM25
force-pushed
the
bugfix/autorepair_fix_invalid_state
branch
from
15e7bb2 to
d3c28fd
Compare
LukaszRozmej
approved these changes
Apr 25, 2023
benaadams
approved these changes
Apr 27, 2023
benaadams
approved these changes
Apr 27, 2023
kamilchodola
pushed a commit
that referenced
this pull request
May 2, 2023
* InvalidBestState fix? retake snapshot add warning fix tests * add test * fix test * one more test for autorepair * fix whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Possible fix of Invalid Best State Calculation observed on syncing some archive nodes. This is automatic repair after the issue happened. Normally, a restart of the node will fix the issue. The root cause: once we have an invalid block during the sync, we
changed best blocks: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Blockchain/BlockTree.cs#L1111
but we can have more blocks that have been already suggested and because of that Invalid Best State Calculation is broken: https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Synchronization/ParallelSync/MultiSyncModeSelector.cs#L674
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
I haven't done testing yet, which is why it is still a draft. It takes a lot of time to sync archive nodes, I will start with this fix and will work on tests in the meantime. For now, I want to check if the fix is working