Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdai-> Gnosis in BlockchainIds and small cleanup #5502

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

MarekM25
Copy link
Contributor

Changes

Applied discord suggestion about BlockchainIds

  • renamed xDai -> Gnosis
  • removed Stureby
  • removed some old comments

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

I ran xdai/gnosis configs to check if there is no unexpected crash on startup

@MarekM25 MarekM25 requested review from marcindsobczak and rubo March 27, 2023 13:36
@MarekM25 MarekM25 merged commit 66e72f4 into master Mar 27, 2023
@MarekM25 MarekM25 deleted the BlockchainIds_cleanup branch March 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants