Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nethermind.ReferenceAssemblies package #5496

Merged
merged 8 commits into from
Mar 28, 2023
Merged

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Mar 24, 2023

Changes

For plugin development, third parties need reference assemblies to compile their projects. To make their experience better, the reference assemblies are published as a NuGet package and as a separate archive to GitHub Releases.

  • The build workflow has been modified to publish Nethermind.ReferenceAssemblies NuGet package on every Nethermind release
  • As a side effect, a new archive with reference assemblies is also published to GitHub Releases
  • Replaced the Deterministic property in the project files with CLI option in the build script

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: New package

Testing

Requires testing

  • Yes
  • No

@LukaszRozmej
Copy link
Member

@MicahZoltu WDYT?

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am excited to get rid of my hacky script that manually copies the reference assemblies from a local build. 😄

scripts/deployment/build-runner.sh Outdated Show resolved Hide resolved
@rubo rubo marked this pull request as ready for review March 28, 2023 18:42
@rubo rubo merged commit 2ade49e into master Mar 28, 2023
@rubo rubo deleted the feature/ref-assemblies branch March 28, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants