Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch off DotNetty ResourceLeakDetector #5421

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Switch off DotNetty ResourceLeakDetector #5421

merged 1 commit into from
Mar 12, 2023

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Mar 12, 2023 •
edited
Loading

Changes

  • Switch off DotNetty's Resource Leak Detector as it is the largest single allocator; and isn't adding high value as there are currently no leak errors being reported

image

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams merged commit be9dc83 into master Mar 12, 2023
@benaadams benaadams deleted the ResourceLeakDetector branch March 12, 2023 01:12
@LukaszRozmej
Copy link
Member

Maybe keep it in Debug build?

@benaadams benaadams mentioned this pull request Mar 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

Assignees

@LukaszRozmej LukaszRozmej

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @LukaszRozmej @asdacap