Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused runtime features #5380

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

benaadams
Copy link
Member

Changes

  • BinaryFormatterSerialization is deprecated and unsafe, so jettison all the code for it from the builds
  • UTF7Encoding is deprecated and unsafe, so jettison all the code for it from the builds
  • Don't think Globalization is particularly used, so jettison all the data for it from the builds (also make some string conversions faster)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 0491250 into master Mar 7, 2023
@LukaszRozmej LukaszRozmej deleted the Remove-unused-runtime-features branch March 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants