Optimize EvmStack

[benaadams]

Changes

• Load and endianness swap in one instruction
• Tail call for Int256
• Move exceptions out of flow
• Move tracing loops out of flow

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[LukaszRozmej]

Running hive tests:
https://github.com/NethermindEth/nethermind/actions/runs/4333660864
https://github.com/NethermindEth/nethermind/actions/runs/4333663830

[benaadams]

Running hive tests: https://github.com/NethermindEth/nethermind/actions/runs/4333660864 https://github.com/NethermindEth/nethermind/actions/runs/4333663830

✖ Invalid Transition Payload Re-Org, Incomplete Transactions, Reveal using sync (nethermind)
✖ Withdraw many accounts (nethermind)

These errors from this change? 🤔

[MarekM25]

Running hive tests: https://github.com/NethermindEth/nethermind/actions/runs/4333660864 https://github.com/NethermindEth/nethermind/actions/runs/4333663830

✖ Invalid Transition Payload Re-Org, Incomplete Transactions, Reveal using sync (nethermind)
✖ Withdraw many accounts (nethermind)

These errors from this change? 🤔

Withdraw many accounts (nethermind) - this test is unstable for sure.
Unfortunately, I think this might be unstable as well:
✖ Invalid Transition Payload Re-Org, Incomplete Transactions, Reveal using sync (nethermind)

[rubo]

These errors from this change? 🤔

@benaadams Nope. They are just flaky.

[asdacap]

QQ: Can you elaborate what you mean by "tail call" here? Does .net have some specific optimication in this case?

[benaadams]

No stack to clean up; return type and parameters match; so in the asm these method just turns into a single jump to the other methods

; Method Nethermind.Evm.EvmStack:PushSignedInt256(byref):this
G_M000_IG01:

G_M000_IG02:
       FF25D23F1400         tail.jmp [Nethermind.Evm.EvmStack:PushUInt256(byref):this]
; Total bytes of code: 6

; Method Nethermind.Evm.EvmStack:PopSignedInt256(byref):this
G_M000_IG01:

G_M000_IG02:
       FF2532401400         tail.jmp [Nethermind.Evm.EvmStack:PopUInt256(byref):this]
; Total bytes of code: 6

[marcindsobczak]

Code looks fine, hive consensus tests are green, if engine tests would pass as well (or we will have same false-positive fails from master) I will feel comfortable with merging it