-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf/improve snap request concurrency #5342
Conversation
src/Nethermind/Nethermind.Blockchain/Synchronization/ISyncConfig.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/SnapSync/ProgressTracker.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there will be always healing required, even for small states because stitching between partitions won't work but I don't think it's a problem.
In general looks good. A few minor comments added.
@kamilchodola we need to run multiple test syncs on mainnet and then Verify the whole tree although it's going to be slow.
We should also test scenarios when we close the node after Phase 1 and start again etc.
src/Nethermind/Nethermind.Blockchain/Synchronization/ISyncConfig.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/SnapSync/ProgressTracker.cs
Outdated
Show resolved
Hide resolved
@damian-orzechowski please also review. |
Aside from the fact that the partitions is going to cause interleaving range from different root hash, why does the stitching does not work? Or do you mean it does not work as well? |
I'll explain on a call. |
limit
parameters, so this works well.Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Sepolia still looking for peer (known issue) and my new ISP have this nasty habit of not working randomly when I start nethermind.It's synced now. Don't know when, just left it on for the whole day.Other notes