Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 15MB of string allocations in SimpleDb.LoadData #5310

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Remove 15MB of string allocations in SimpleDb.LoadData #5310

merged 2 commits into from
Feb 20, 2023

Conversation

benaadams
Copy link
Member

Changes

  • Operate over Span<byte> rather than allocating strings via ReadAllLines and string.Split

Types of changes

Before

image

After

image

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes - adjusted existing tests
  • No

@LukaszRozmej LukaszRozmej merged commit 55b8873 into NethermindEth:master Feb 20, 2023
@benaadams benaadams deleted the SimpleDb-allocations branch February 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej