-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't disconnect peers on fast sync criteria #5293
Don't disconnect peers on fast sync criteria #5293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked this code on any node? I wonder how it works in practice. I can imagine that thanks to that code we still drop lots of unuseful peers so it might affect our networking a lot potentially
src/Nethermind/Nethermind.Synchronization/Peers/SyncPeerPool.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smartprogrammer93 is right, DropWorstPeer doesn't look like something that should be removed
…-peers-on-fast-sync-criteria
Synced my node on it, looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed code looks not needed
Changes
Open question:
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Should be tested on actual networks