Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disconnect peers on fast sync criteria #5293

Merged

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Feb 15, 2023

Changes

Open question:

  • Should we still disconnect, but only when we are syncing?

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Should be tested on actual networks

@LukaszRozmej LukaszRozmej requested a review from flcl42 February 15, 2023 14:37
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked this code on any node? I wonder how it works in practice. I can imagine that thanks to that code we still drop lots of unuseful peers so it might affect our networking a lot potentially

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smartprogrammer93 is right, DropWorstPeer doesn't look like something that should be removed

@LukaszRozmej
Copy link
Member Author

Synced my node on it, looks fine.

Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed code looks not needed

@LukaszRozmej LukaszRozmej merged commit 6d601bc into master Mar 9, 2023
@LukaszRozmej LukaszRozmej deleted the fix/dont-disconnect-peers-on-fast-sync-criteria branch March 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants