Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move block recovery signature step to be multi-threaded #5288

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Move block recovery signature step to be multi-threaded #5288

merged 2 commits into from
Feb 14, 2023

Conversation

LukaszRozmej
Copy link
Member

Changes

  • for -> Parallel.For

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

MarekM25
MarekM25 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now we should check the metrics

@LukaszRozmej LukaszRozmej merged commit 1e2ce1e into master Feb 14, 2023
@LukaszRozmej LukaszRozmej deleted the perf/recover-senders-multi-thread branch February 14, 2023 15:03
MarekM25 pushed a commit that referenced this pull request Mar 10, 2023
@LukaszRozmej @MarekM25
Move block recovery signature step to be multi-threaded (#5288)
0905d36 
(cherry picked from commit 1e2ce1e)
MarekM25 pushed a commit that referenced this pull request Mar 13, 2023
@LukaszRozmej @MarekM25
Move block recovery signature step to be multi-threaded (#5288)
6526574 
(cherry picked from commit 1e2ce1e)
(cherry picked from commit 0905d36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@Scooletz Scooletz Awaiting requested review from Scooletz

@OlegJakushkin OlegJakushkin Awaiting requested review from OlegJakushkin

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukaszRozmej @MarekM25 @benaadams