Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/max open files flag and write rates limit #5287

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Feb 14, 2023

  • Expose max open file settings.
    • Useful to prevent crash under very heavy compaction.
  • Expose write rate limit.
    • Useful to limit the effect of compaction writes whose otherwise can't be controlled easily.

Changes

  • Extract db settings handling to its own file.
  • Expose max open files settings.
  • Expose write rate limit settings.

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Open files handle seems to be capped when checking via collectd.
  • Write rates limit seems to work also, but not very smooth.

@asdacap asdacap merged commit 6575d6c into master Feb 14, 2023
@asdacap asdacap deleted the feature/max-open-files-flag branch February 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants