Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose ArrayPoolList after use #5285

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Dispose ArrayPoolList after use #5285

merged 1 commit into from
Feb 13, 2023

Conversation

benaadams
Copy link
Member

Changes

  • Dispose the couple ones that weren't
  • Remove one that is unnecessary (can enumerate and remove from a concurrent dict at same time)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit 0f56fce into NethermindEth:master Feb 13, 2023
@benaadams benaadams deleted the ArrayPoolList-Dispose branch February 13, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej