Bugfix/eip3860 reject invalid TXs from TxPool #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
requested review from
damian-orzechowski,
LukaszRozmej and
smartprogrammer93
LukaszRozmej
approved these changes
Jan 16, 2023
|
|
||
| private bool Validate3860Rules(Transaction transaction, IReleaseSpec releaseSpec) | ||
| { | ||
| bool aboveInitCode = transaction.IsContractCreation && releaseSpec.IsEip3860Enabled && (transaction.Data?.Length ?? 0) > releaseSpec.MaxInitCodeSize; |
There was a problem hiding this comment.
(transaction.Data?.Length ?? 0) this is in few places, can we introduce on Transaction object property:
DataLength => Data?.Length ?? 0 to avoid this check in multiple places? (There are 2 other in solution outside this PR)
damian-orzechowski
approved these changes
Jan 16, 2023
MarekM25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect transactions should be removed from TxPool.
TransactionSelectorTests.cs and TransactionsExecutorTests.cs was refactored because I planned to add these changes to BlockProcessor.BlockProductionTransactionPicker.cs https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.BlockProductionTransactionPicker.cs
However, TxValidator will be the better place, because we will reject the blocks sooner in the pipeline and reject them from our TxPool.