Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/header sync still throw errors #5119

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jan 10, 2023

  • Fix header sync still throw error.

Changes

  • A lock to prevent processing and updating header pointer when resetting.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@asdacap asdacap merged commit 9ca61f9 into master Jan 10, 2023
@asdacap asdacap deleted the fix/header-sync-still-throw-errors branch January 10, 2023 13:23
kamilchodola pushed a commit that referenced this pull request Jan 18, 2023
* Fix heaader sync still throw error

* Optimize header sync feed

* Revert "Optimize header sync feed"

This reverts commit dd2cdea.

* Add a unit test

* Remove synchronized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants