Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the release workflow #5095

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix the release workflow #5095

merged 1 commit into from
Jan 4, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jan 4, 2023

Changes

Fixed output variable handling in the release workflow.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or a feature that would cause existing functionality not to work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional or API changes)
  • Build-related changes
  • Other: description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@rubo rubo requested a review from kamilchodola January 4, 2023 18:20
@rubo rubo marked this pull request as ready for review January 4, 2023 18:21
@rubo rubo requested a review from FalcoXYZ January 4, 2023 19:16
FalcoXYZ
FalcoXYZ approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@FalcoXYZ FalcoXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubo rubo merged commit ec8110c into master Jan 4, 2023
@rubo rubo deleted the hotfix/prerelease-workflow branch January 4, 2023 19:38
kamilchodola pushed a commit that referenced this pull request Jan 4, 2023
@rubo @kamilchodola
Fix release workflow (#5095)
07b9f06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FalcoXYZ FalcoXYZ FalcoXYZ approved these changes

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubo @FalcoXYZ