Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnosis config #5057

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Add gnosis config #5057

merged 9 commits into from
Dec 28, 2022

Conversation

jmederosalvarado
Copy link
Member

Changes:

  • Renames xdai chainspec to gnosis
  • Adds new config gnosis

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): Config

@jmederosalvarado jmederosalvarado marked this pull request as ready for review December 26, 2022 16:07
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question - Could renaming changespec (instead of having a clone), cause issues when upgrading existing nodes?

@jmederosalvarado
Copy link
Member Author

jmederosalvarado commented Dec 27, 2022

Question - Could renaming changespec (instead of having a clone), cause issues when upgrading existing nodes?

I tested it, at least with a simple setup using --config xdai it is not an issue, I think probably because of chainspec as embedded resource

@LukaszRozmej
Copy link
Member

Question - Could renaming changespec (instead of having a clone), cause issues when upgrading existing nodes?

I tested it, at least with a simple setup using --config xdai it is not an issue, I think probably because of chainspec as embedded resource

Yes with embedded one no issue, with custom one there could be an issue. Can we leave xdai chainspec to be more compatible for now?

@rubo
Copy link
Contributor

rubo commented Dec 27, 2022

Are all those configs actually used? If some aren't, let's remove those. Not sure about the rest but the ndm_* stuff looks obsolete.

@LukaszRozmej
Copy link
Member

I think ndm*, _mev, _validator configs can be safely removed

@LukaszRozmej LukaszRozmej merged commit a93d4aa into master Dec 28, 2022
@LukaszRozmej LukaszRozmej deleted the config/add_gnosis_config branch December 28, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants