Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nethermind_blocks update when a trace block is called. #4970

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 7, 2022

Fix #4943

  • When calling trace, the blockchainproccessor is run, and the metrics is (probably?) wrongly updated. This seems to be an unexpected behaviour.
  • Additionally nethermind_blocks mentioned in its description as total number of block processed. Strictly speaking, this is not what we implement, which is the current block height. Even our own dashboard uses this as block height instead of total blocks processed. So I'm not gonna change this behaviour.

Changes:

  • If readonly chain, don't update metrics.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

  • Tested manually, before trace_block would cause metric on my dashboard to change, now trace_block no longer change the metric.

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap asdacap requested a review from LukaszRozmej December 7, 2022 10:12
@asdacap asdacap merged commit 9dc1d6b into master Dec 9, 2022
@asdacap asdacap deleted the fix/4943-incorrect-blockheight-metrics branch December 9, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node under heavy JSON-RPC load reports incorrect height from metric module
2 participants