Added a Block Config separate from Mining Config to reduce PoS confusion (issue #4836) #4847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4836
The issue was that
Mining.Enabled
(that is extremely rarely used) made a user confused if it is needed to have the ability to set other Block creation parameters. With this PR, we enable Block parameters configuration separate from Mining parameter(s).Backward compatibility and synchronisation are enabled on the
MigrateConfigs
step.In other words, one might set, for example,
Mining.Enabled
,Mining.RandomizedBlocks
,Blocks.RandomizedBlocks
Blocks.ExtraData
at the same time and:RandomizedBlocks
is the same on Mining and Blocks continue, otherwise get an exceptionChanges:
Types of changes
Testing
Added unit tests to test functionality as it is mostly cosmetic
In case you checked yes, did you write tests?