Fixed ExtraData in MiningConfig #4665 #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added it to referenced in the issue-4665 locations and their references
MarekM25
reviewed
Oct 7, 2022
| @@ -113,8 +115,58 @@ public virtual async Task forkchoiceUpdatedV1_should_communicate_with_boost_rela | |||
| .WithContent("{\"timestamp\":\"0x3e8\",\"prevRandao\":\"0x0000000000000000000000000000000000000000000000000000000000000000\",\"suggestedFeeRecipient\":\"0x0000000000000000000000000000000000000000\"}") | |||
| .Respond("application/json", "{\"timestamp\":\"0x3e9\",\"prevRandao\":\"0x03783fac2efed8fbc9ad443e592ee30e61d65f471140c10ca155e937b435b760\",\"suggestedFeeRecipient\":\"0xb7705ae4c6f81b66cdb323c65f4e8133690fc099\"}"); | |||
|
|
|||
| //TODO: think about extracting an essely serialisable class, test its serializatoin sepratly, refactor with it similar methods like the one above | |||
There was a problem hiding this comment.
Minor thing - typo: sepratly
MarekM25
reviewed
Oct 7, 2022
LukaszRozmej
approved these changes
Oct 11, 2022
Missed the constant variable override
|
@MarekM25 Please review the update (1 hardcoded hash line update) |
|
Samples of configuration in-use Shout out to the Angkor team; thanks for your help in the testing of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4665
Changes:
ExtraDatais hardcoded in different ways.ExtraDatafromIMiningConfigand expands on preexisting ExtraData roots inMiningConfigTypes of changes
Testing
Requires testing
Tested locally with Goreli, Unit Tested locally, requires wider testing as the this is implementer's first issue
In case you checked yes, did you write tests??
All new code developed in the fixing of this issue has Unit Tests
MiningConfigTest.csComments about testing, should you have some (optional)
Not 100% of unit tests do currently pass on stand-alone windows (yet the same amount of tests fail on this PR Unit test results as on Master nethermind brunch)