Fix logIndex in logs subscription

[marcindsobczak]

Changes:

• fix logIndex in logs subscription

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Other (please describe):

Testing

Requires testing

• Yes
• No

In case you checked yes, did you write tests??

• Yes (adjusted existing ones - results expected by me when implementing eth_subscribe were wrong)
• No

[marcindsobczak]

I tested it by sending requests on goerli testnet. Checked behaviour on:

1. current master
2. this branch

I picked address "0x607f755149cfeb3a14e1dc3a4e2450cde7dfb04d" which was regularly sending requests on goerli network and I tested requests:

1. {"method":"eth_subscribe","params":["logs",{"address":"0x607f755149cfeb3a14e1dc3a4e2450cde7dfb04d"}],"id":1,"jsonrpc":"2.0"}
2. curl --data '{"method":"eth_getLogs","params":[{"fromBlock":"<blockFromSubscription>","toBlock":"<blockFromSubscription>","address":"0x607f755149cfeb3a14e1dc3a4e2450cde7dfb04d"}],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545

From master - results same as in reported issue:

From this branch - result as expected - same logIndex in eth_subscribe and in eth_getLogs:

Looks fine and mergable.

[asdacap]

LGTM

[vyzaldysanchez]

Any idea on when this fix is going to be released?

[rubo]

@vyzaldysanchez There's a pre-release including this.