Refactor/generic send request #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Oct 7, 2022
| _bodiesRequests, | ||
| message, | ||
| TransferSpeedType.Bodies, | ||
| static (message) => $"{nameof(GetBlockBodiesMessage)} with {message.BlockHashes.Count} block hashes", |
There was a problem hiding this comment.
Is the string computed as a constant on compile?
There was a problem hiding this comment.
I dont think so, it only prevent allocation from the lambda.
|
What is that? |
|
marcindsobczak
approved these changes
Oct 7, 2022
rubo
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Generic send request * Fix wrong transfer speed * Micro optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor as mentioned by the attribute.
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Goerli can sync to head.
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...