Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid block on mainnet #4695

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Oct 4, 2022

Rollback a package config.

Changes:

  • Rollback a package config

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Seems to work... locally at least.

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubo this needs investigation what is wrong with the package

@asdacap asdacap merged commit 4d69422 into master Oct 4, 2022
@asdacap asdacap deleted the fix/random-invalid-block-on-mainnet branch October 4, 2022 09:27
rubo added a commit that referenced this pull request Oct 4, 2022
Andrew-Pohl pushed a commit to fuseio/nethermind that referenced this pull request Oct 7, 2022
* Fix invalid block on mainnet

* Add submodule
rubo added a commit that referenced this pull request Oct 10, 2022
rubo added a commit that referenced this pull request Oct 10, 2022
* Revert "Fix Dockerfile after bringing Math submodule (#4708)"

This reverts commit 2c31eb6.

* Revert "Fix invalid block on mainnet (#4695)"

This reverts commit 4d69422.

* Update Nethermind.Gmp package
rubo pushed a commit that referenced this pull request Oct 13, 2022
* Fix invalid block on mainnet

* Add submodule
rubo added a commit that referenced this pull request Oct 13, 2022
* Revert "Fix Dockerfile after bringing Math submodule (#4708)"

This reverts commit 2c31eb6.

* Revert "Fix invalid block on mainnet (#4695)"

This reverts commit 4d69422.

* Update Nethermind.Gmp package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants