Limit request size per peer #4692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
asdacap
force-pushed
the
perf/limited-request-size
branch
from
936bcc3 to
f078842
Compare
Comment on lines
+9
to
+12
| if (length > readOnlyList.Count) | ||
| { | ||
| return readOnlyList; | ||
| } |
There was a problem hiding this comment.
The original type like List<> can still grow, so we shouldn't ever use this path
There was a problem hiding this comment.
Why? Its a read only list?
Comment on lines
+154
to
188
| int startingReceiptsCountLimit = _getReceiptsCurrentBatchSize; | ||
| GetReceiptsMessage msg = new(blockHashes.CappedTo(startingReceiptsCountLimit)); | ||
|
|
||
| try | ||
| { | ||
| Stopwatch sw = Stopwatch.StartNew(); | ||
| TxReceipt[][] txReceipts = await SendRequest(msg, token); | ||
|
|
||
| long elapsed = sw.ElapsedMilliseconds; | ||
| if (elapsed < GetReceiptsLatencyLowWatermark && txReceipts.Length == startingReceiptsCountLimit) | ||
| { | ||
| _getReceiptsCurrentBatchSize = Math.Min( | ||
| (int)Math.Ceiling(startingReceiptsCountLimit * GetReceiptsBatchSizeAdjustmentFactor), | ||
| GetReceiptsMaxBatchSize | ||
| ); | ||
| } | ||
| else if (elapsed > GetReceiptsLatencyHighWatermark) | ||
| { | ||
| _getReceiptsCurrentBatchSize = Math.Max( | ||
| (int)Math.Floor(startingReceiptsCountLimit / GetReceiptsBatchSizeAdjustmentFactor), | ||
| GetReceiptsMinBatchSize | ||
| ); | ||
| } | ||
|
|
||
| return txReceipts; | ||
| } | ||
| catch (Exception) | ||
| { | ||
| _getReceiptsCurrentBatchSize = Math.Max( | ||
| (int)Math.Floor(startingReceiptsCountLimit / GetReceiptsBatchSizeAdjustmentFactor), | ||
| GetReceiptsMinBatchSize | ||
| ); | ||
| throw; | ||
| } | ||
| } |
There was a problem hiding this comment.
We have this code very similar in two places, should we make it reusable somehow?
I thought I should push a PR for sync metrics first to see the reduced timeout, if any on server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...