Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node speed does not update #4646

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Sep 27, 2022

Fix node speed does not update after some time as observation count increase. This means node that suddenly become slower does not get its speed reflected.

Changes:

  • Uses different speed calculation.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • [] No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@asdacap
Copy link
Contributor Author

asdacap commented Sep 27, 2022

One node (lighthouse) stuck on forward sync due to other known issue. 3 other node synced and processing block, No clear improvement or regression.

@asdacap asdacap marked this pull request as ready for review September 27, 2022 09:17
@asdacap asdacap merged commit ecce495 into master Sep 29, 2022
@asdacap asdacap deleted the fix/node-speed-does-not-update branch September 29, 2022 13:35
Andrew-Pohl pushed a commit to fuseio/nethermind that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants