Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not allow StateNodes if Snap Ranges is not finished #4549

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

dceleda
Copy link
Member

@dceleda dceleda commented Sep 9, 2022

Fixes #4502

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dceleda could you add unit tests?

@dceleda dceleda force-pushed the bug/4502_SnapToStateNodesSwitching branch from be7aa1a to 7aa697d Compare September 25, 2022 16:59
@dceleda dceleda force-pushed the bug/4502_SnapToStateNodesSwitching branch from 937d906 to 958f823 Compare September 25, 2022 18:58
@dceleda dceleda requested a review from MarekM25 September 25, 2022 19:51
@kamilchodola kamilchodola merged commit a87df23 into master Sep 25, 2022
@kamilchodola kamilchodola deleted the bug/4502_SnapToStateNodesSwitching branch September 25, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snap Sync] SNAP Phase1 and State Healing are running in the same time
4 participants