Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync NewPayload #4409

Merged
merged 2 commits into from
Aug 12, 2022
Merged

fix sync NewPayload #4409

merged 2 commits into from
Aug 12, 2022

Conversation

MarekM25
Copy link
Contributor

@MarekM25 MarekM25 commented Aug 11, 2022

After merging invalid ancestor hive tests we introduced regression:
#4390 (comment)

https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Merge.Plugin/MergeBetterPeerStrategy.cs#L70

We don't have BeaconPivot in this cases, so we won't be able to sync

Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, make sense

@MarekM25 MarekM25 marked this pull request as ready for review August 12, 2022 08:09
@MarekM25 MarekM25 merged commit 42f4130 into master Aug 12, 2022
@MarekM25 MarekM25 deleted the fix_sync branch August 12, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants