Remove upper limit for ChainLevelHelper.GetNextHeader #4373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
our unit tests are failing |
|
Fixed |
MarekM25
approved these changes
Aug 8, 2022
MarekM25
reviewed
Aug 8, 2022
| @@ -110,6 +110,13 @@ public class MergeBlockDownloader : BlockDownloader | |||
|
|
|||
| bool HasMoreToSync(out BlockHeader[]? headers, out int headersToRequest) | |||
| { | |||
| if (!_beaconPivot.BeaconPivotExists()) | |||
There was a problem hiding this comment.
This condition is wrong. We can have situation when we don't have beacon pivot and we want to sync.
There was a problem hiding this comment.
what do you think about Math.Min(ProcessDestination, BestKnownNumber) >= BestKnownBeaconNumber?
There was a problem hiding this comment.
Imagine that you have timeout in NewPayloadHandler. For the next payload we insert it without cache and return SYNCING. We don't have beaconPivot in this situation.
asdacap
force-pushed
the
remove-chainlevelhelper-upper-limit
branch
from
ec509ed to
d361bee
Compare
MarekM25
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...