Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Broadcast of full blocks before processing block #4365

Merged
merged 25 commits into from
Aug 10, 2022
Merged

Move Broadcast of full blocks before processing block #4365

merged 25 commits into from
Aug 10, 2022

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Aug 4, 2022 •
edited
Loading

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@LukaszRozmej LukaszRozmej requested a review from MarekM25 August 4, 2022 15:30
@LukaszRozmej
Fix and add tests.
537bed4 
Improve peer selection when broadcasting full block.
@LukaszRozmej
Merge remote-tracking branch 'origin/master' into broadcast-blocks
f5e55d1 
# Conflicts:
#	src/Nethermind/Nethermind.Synchronization.Test/SyncServerTests.cs
#	src/Nethermind/Nethermind.Synchronization/SyncServer.cs
@LukaszRozmej
Remove isBlockTotalDifficultyLow = block.TotalDifficulty < (_blockTre…
f1ca6b7 
…e.BestSuggestedHeader?.TotalDifficulty ?? UInt256.Zero) part of condition to allow insterting to tree last 512 VALIDATED blocks.
@LukaszRozmej
Rename SendBlockPriority to SendBlockMode
136c288
@LukaszRozmej
Add additional CanGossipBlocks check.
0519ed0
@LukaszRozmej
Move default config level to trace
0447573
@LukaszRozmej
Bring back total difficulty for broadcast
cfee460
@LukaszRozmej
Increase timeouts for hive and payload cleanup
9ce0aac
@LukaszRozmej
Add log level override to hive tests
4e9cf17
@LukaszRozmej
Improve logging on NewBlockMessage
8da88ac
@LukaszRozmej
Improve broadcast
a100ae2
@LukaszRozmej
More fixes
ba8c792
@LukaszRozmej
Revert "Increase timeouts for hive and payload cleanup"
8289e90 
This reverts commit 9ce0aac.
@LukaszRozmej
Merge remote-tracking branch 'origin/master' into broadcast-blocks
05a7fa8
@LukaszRozmej
Add Ethash timestamp validation with 15s into the future.
12b6c89
@LukaszRozmej LukaszRozmej requested a review from MarekM25 August 10, 2022 10:05
@LukaszRozmej LukaszRozmej merged commit 03a88af into master Aug 10, 2022
@LukaszRozmej LukaszRozmej deleted the broadcast-blocks branch August 10, 2022 12:17
@LukaszRozmej
Copy link
Member Author

Looks to work fine on my node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak Awaiting requested review from marcindsobczak

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukaszRozmej @MarekM25 @marcindsobczak