Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for MiningConfig.MinGasPrice to zero #4329

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

jmederosalvarado
Copy link
Member

Changes:

  • Changes the default value for MiningConfig.MinGasPrice to zero on all networks except for gnosis/xdai

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): Config

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@jmederosalvarado jmederosalvarado force-pushed the min-gas-price-default-to-zero branch from 685d719 to b452892 Compare July 28, 2022 16:53
@LukaszRozmej
Copy link
Member

Now we will accept free transactions by default, do we want it or move to 1.Wei?

@jmederosalvarado jmederosalvarado force-pushed the min-gas-price-default-to-zero branch from 6c1d3d5 to 8032852 Compare August 1, 2022 21:25
@LukaszRozmej LukaszRozmej merged commit 2c72845 into master Aug 3, 2022
@LukaszRozmej LukaszRozmej deleted the min-gas-price-default-to-zero branch August 3, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants