Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keys to keyStoreDirectory #4320

Merged
merged 20 commits into from
Feb 23, 2023
Merged

Move keys to keyStoreDirectory #4320

merged 20 commits into from
Feb 23, 2023

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented Jul 26, 2022 •
edited
Loading

Fixes | Closes | Resolves
#4305

Changes:

  • Protection keys moved from SpecialFolder to keyStoreDirectory

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

@deffrian deffrian linked an issue Jul 26, 2022 that may be closed by this pull request
Nethermind ignores --datadir for keys #4305
Closed
@deffrian deffrian requested review from dceleda and MarekM25 July 26, 2022 20:10
LukaszRozmej
LukaszRozmej reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it backwards compatible?

@deffrian
Copy link
Contributor Author

deffrian commented Aug 3, 2022

Is it backwards compatible?

No, it will generate new keys in keystore directory

@MarekM25
Copy link
Contributor

MarekM25 commented Aug 4, 2022

Is it backwards compatible?

No, it will generate new keys in keystore directory

So I guess we can't work in this way

attila-lendvai
attila-lendvai reviewed Dec 19, 2022
View reviewed changes
Copy link

@attila-lendvai attila-lendvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are excessive whitespace changes in the commits, which makes reviewing and tracking the change/commit history harder.

attila-lendvai
attila-lendvai reviewed Dec 19, 2022
View reviewed changes
Copy link

@attila-lendvai attila-lendvai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleting accidental double post]

@attila-lendvai
Copy link

FTR, i'm bitten by this on Guix, i.e. a non-docker based setup.

@tkstanczak
Copy link
Member

@matilote

@LukaszRozmej LukaszRozmej merged commit 71fb576 into master Feb 23, 2023
@LukaszRozmej LukaszRozmej deleted the 4305-nethermind-ignores-datadir-for-keys branch February 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attila-lendvai attila-lendvai attila-lendvai left review comments

@damian-orzechowski damian-orzechowski damian-orzechowski approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@dceleda dceleda Awaiting requested review from dceleda

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nethermind ignores --datadir for keys
6 participants
@deffrian @MarekM25 @attila-lendvai @tkstanczak @LukaszRozmej @damian-orzechowski