Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward exeption on fast block #4193

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Forward exeption on fast block #4193

merged 2 commits into from
Jun 23, 2022

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 23, 2022

  • Did not realize that the request was timing out until I added breakpoints.
  • Exception should be logged

Changes:

  • Forward exception during dispatch.

Testing

  • Timeout now get logged.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are handling all paths, maybe just change to standard await instead of ContinueWith?
Where that exception will propagate to?

@asdacap
Copy link
Contributor Author

asdacap commented Jun 23, 2022

Thats what I thought, why is it using ContinueWith?. The exception is logged by SyncDispatcher.

@LukaszRozmej
Copy link
Member

Thats what I thought, why is it using ContinueWith?. The exception is logged by SyncDispatcher.

ContinueWith is useful in cases where we don't await or we handle only some scenarios, with await we need to handle all of them.

@asdacap asdacap force-pushed the log-on-fastblock-error branch from d19d8cc to d6c6d83 Compare June 23, 2022 10:36
@asdacap asdacap requested a review from LukaszRozmej June 23, 2022 10:42
@LukaszRozmej LukaszRozmej merged commit ad72e01 into master Jun 23, 2022
@LukaszRozmej LukaszRozmej deleted the log-on-fastblock-error branch June 23, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants