Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate AuRaTxFilters in order to disable them post merge #4182

Merged
merged 4 commits into from
Jun 22, 2022

Conversation

jmederosalvarado
Copy link
Member

Changes:

  • Disable all AuRa TxFilters post-merge in AuRaMergePlugin

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing, should you have some

Tested using posdao test setup

@LukaszRozmej
Copy link
Member

LukaszRozmej commented Jun 22, 2022

I've simplified it a bit and fixed issue of fallback filter for MinGasPrice.
Is there a potential issue that we have a system transaction in TxPool already, that we should remove on PoS transition?

@LukaszRozmej LukaszRozmej merged commit 7418498 into master Jun 22, 2022
@LukaszRozmej LukaszRozmej deleted the fix/aura_tx_filters branch June 22, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants