Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and Dockerfile for new dependency on arm64 #4109

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

FalcoXYZ
Copy link
Contributor

@FalcoXYZ FalcoXYZ commented Jun 3, 2022

Changes:

Updated README to add the symlink for arm64 architecture.
Updated Dockerfile to add the libgflags-dev dependency for arm64 architecture.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Tested Dockerfile on arm64 EC2, libgflags-dev was installed as expected.

FalcoXYZ added 2 commits June 3, 2022 15:47
Add extra dependency for arm64 to readme and the symlink for arm64/aarch64
add libgflags-dev dependency to arm64
@FalcoXYZ FalcoXYZ added the devops label Jun 3, 2022
@FalcoXYZ FalcoXYZ requested a review from AntiD2ta June 3, 2022 15:11
@AntiD2ta AntiD2ta marked this pull request as ready for review June 3, 2022 15:30
@AntiD2ta AntiD2ta merged commit 3c2d7a7 into master Jun 3, 2022
@AntiD2ta AntiD2ta deleted the update-dependency branch June 3, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants