Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache local txs in PeerInfo #3813

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Do not cache local txs in PeerInfo #3813

merged 7 commits into from
Feb 16, 2022

Conversation

marcindsobczak
Copy link
Contributor

Changes:

  • Do not add local transactions to cache in PeerInfo (when broadcasting txs)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@marcindsobczak
changes
8d56e0a
@marcindsobczak
simplification in PeerInfo
90c1e54
@marcindsobczak
reverse dependency in ITxPoolPeer
71b31b1
@marcindsobczak
cosmetic
b26e2ee
@marcindsobczak
Merge branch 'refactor/local_txs_broadcasting' into refactor/dont_cac…
3071092 
…he_local_txs

# Conflicts:
#	src/Nethermind/Nethermind.TxPool.Test/TxBroadcasterTests.cs
#	src/Nethermind/Nethermind.TxPool/TxBroadcaster.cs
@LukaszRozmej LukaszRozmej merged commit 50b4cc4 into master Feb 16, 2022
@LukaszRozmej LukaszRozmej deleted the refactor/dont_cache_local_txs branch February 16, 2022 09:02
marcindsobczak added a commit that referenced this pull request Feb 24, 2022
@marcindsobczak
Revert "Do not cache local txs in PeerInfo (#3813)"
57e9427 
This reverts commit 50b4cc4.
LukaszRozmej pushed a commit that referenced this pull request Mar 1, 2022
@marcindsobczak
Refactor persistent broadcast (#3847)
84e7028 
* Revert "Do not cache local txs in PeerInfo (#3813)"

This reverts commit 50b4cc4.

* refactor

* fixes

* cosmetic

* cosmetic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcindsobczak @LukaszRozmej