Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xdai/minimal base fee #3576

Merged
merged 8 commits into from
Nov 4, 2021
Merged

Xdai/minimal base fee #3576

merged 8 commits into from
Nov 4, 2021

Conversation

LukaszRozmej
Copy link
Member

Changes:

Add minimal BaseFee mechanism for xdai

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

External testing by POA

@tkstanczak tkstanczak self-requested a review November 3, 2021 15:38
tkstanczak
tkstanczak requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@tkstanczak tkstanczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being introduced to set the min base fee?

@LukaszRozmej
Revert "update xdai chainspec"
8ba9b69 
This reverts commit 842d958.
@LukaszRozmej
Revert "chuck testa"
5f23a9a 
This reverts commit 69e1269.

# Conflicts:
#	src/Nethermind/Nethermind.Specs.Test/ChainSpecStyle/ChainSpecLoaderTests.cs
@LukaszRozmej LukaszRozmej merged commit 2a7b759 into master Nov 4, 2021
@LukaszRozmej LukaszRozmej deleted the xdai/minimal_base_fee branch November 4, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkstanczak tkstanczak tkstanczak requested changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukaszRozmej @tkstanczak @marcindsobczak