Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce .NET 6.0 #3554

Merged
merged 30 commits into from
Nov 19, 2021
Merged

Introduce .NET 6.0 #3554

merged 30 commits into from
Nov 19, 2021

Conversation

matilote
Copy link
Member

@matilote matilote commented Oct 27, 2021

Fixes | Closes | Resolves #2571

Changes:

Migrate codebase from .NET 5.0 to .NET 6.0.
Support M1 (Apple Silicon) machines with osx-arm64 runtime.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

Further comments (optional)

The minimal hosting model:

  • Significantly reduces the number of files and lines of code required to create an app. Only one file is needed with four lines of code.

  • Unifies Startup.cs and Program.cs into a single Program.cs file.

  • Uses top-level statements to minimize the code required for an app.

  • Uses global using directives to eliminate or minimize the number of using statement lines required.

  • I had to create a symlink to libsnappy to run the node, otherwise the dll was not being found

sudo ln -s /opt/homebrew/Cellar/snappy/1.1.9/lib/libsnappy.1.1.9.dylib /usr/local/lib/libsnappy.dylib

@LukaszRozmej
Copy link
Member

@matilote @1swaraj can you update our github actions to support .net6? Next lets build some test package/docker and test on different environments.

@LukaszRozmej
Copy link
Member

LukaszRozmej commented Nov 11, 2021

I don't think we need to change our hosting model at this point, it works fine. I will look into warnings.

@matilote matilote marked this pull request as ready for review November 19, 2021 09:25
@MarekM25 MarekM25 self-requested a review November 19, 2021 09:52
@matilote matilote merged commit 6744770 into master Nov 19, 2021
@matilote matilote deleted the feature/net6.0 branch November 19, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Apple Silicon
3 participants