Implementation trace get

src/Nethermind/Nethermind.Evm/Tracing/ParityStyle/ParityLikeBlockTracer.cs

@@ -14,6 +14,7 @@
 //  You should have received a copy of the GNU Lesser General Public License
 //  along with the Nethermind. If not, see <http://www.gnu.org/licenses/>.
 
+using System.Collections.Generic;
 using System.Linq;
 using Nethermind.Core;
 using Nethermind.Core.Crypto;
@@ -60,10 +61,10 @@ protected override ParityLikeTxTracer OnStart(Transaction? tx) =>
 
         public override void ReportReward(Address author, string rewardType, UInt256 rewardValue)
         {
-            ParityLikeTxTrace rewardTrace = TxTraces.LastOrDefault();
-            if (rewardTrace == null)
+           ParityLikeTxTrace rewardTrace = TxTraces.LastOrDefault();
+           if (rewardTrace == null)
                 return;
-            
+
             rewardTrace.Action = new ParityTraceAction();
             rewardTrace.Action.RewardType = rewardType;
             rewardTrace.Action.Value = rewardValue;
@@ -72,6 +73,8 @@ public override void ReportReward(Address author, string rewardType, UInt256 rew
             rewardTrace.Action.TraceAddress = new int[] { };
             rewardTrace.Action.Type = "reward";
             rewardTrace.Action.Result = null;
+
+
         }
 
         public override void StartNewBlockTrace(Block block)

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/ITraceRpcModule.cs

@@ -54,7 +54,7 @@ public interface ITraceRpcModule : IRpcModule
         ResultWrapper<ParityTxTraceFromStore[]> trace_block([JsonRpcParameter(ExampleValue = "latest")] BlockParameter numberOrTag);
 
         [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = false)]
-        ResultWrapper<ParityTxTraceFromStore[]> trace_get(Keccak txHash, int[] positions);
+        ResultWrapper<ParityTxTraceFromStore[]> trace_get(Keccak txHash, long[] positions);
 
         [JsonRpcMethod(Description = "", IsImplemented = true, 
             IsSharable = false,

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/ParityTxTraceFromReplay.cs

@@ -36,6 +36,19 @@ public ParityTxTraceFromReplay(ParityLikeTxTrace txTrace, bool includeTransactio
             TransactionHash = includeTransactionHash ? txTrace.TransactionHash : null;
         }
 
+        public ParityTxTraceFromReplay(IReadOnlyCollection<ParityLikeTxTrace> txTraces, bool includeTransactionHash = false)
+        {
+            foreach (ParityLikeTxTrace txTrace in txTraces)
+            {
+                Output = txTrace.Output;
+                VmTrace = txTrace.VmTrace;
+                Action = txTrace.Action;
+                StateChanges = txTrace.StateChanges;
+                TransactionHash = includeTransactionHash ? txTrace.TransactionHash : null;
+            }
+
+        }
+
         public byte[] Output { get; set; }
 
         public Keccak TransactionHash { get; set; }

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/ParityTxTraceFromStore.cs

@@ -30,6 +30,18 @@ public static ParityTxTraceFromStore[] FromTxTrace(ParityLikeTxTrace txTrace)
             AddActionsRecursively(results, txTrace, txTrace.Action);
             return results.ToArray();
         }
+
+        public static ParityTxTraceFromStore[] FromTxTrace(IReadOnlyCollection<ParityLikeTxTrace> txTrace)
+        {
+            List<ParityTxTraceFromStore> results = new();
+            foreach (ParityLikeTxTrace tx in txTrace)
+            {
+                AddActionsRecursively(results, tx, tx.Action);
+            }
+
+            return results.ToArray(); 
+
+        }
 
         private static void AddActionsRecursively(List<ParityTxTraceFromStore> results, ParityLikeTxTrace txTrace, ParityTraceAction txTraceAction)
         {

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

@@ -16,6 +16,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.Linq;
 using System.Threading;
 using MathNet.Numerics.Distributions;
@@ -129,7 +130,7 @@ public ResultWrapper<ParityTxTraceFromReplay> trace_replayTransaction(Keccak txH
 
             Block block = blockSearch.Object;
 
-            ParityLikeTxTrace txTrace = TraceTx(block, txHash, GetParityTypes(traceTypes));
+            IReadOnlyCollection<ParityLikeTxTrace> txTrace = TraceTx(block, txHash, GetParityTypes(traceTypes));
             return ResultWrapper<ParityTxTraceFromReplay>.Success(new ParityTxTraceFromReplay(txTrace));
         }
 
@@ -189,9 +190,21 @@ public ResultWrapper<ParityTxTraceFromStore[]> trace_block(BlockParameter blockP
             return ResultWrapper<ParityTxTraceFromStore[]>.Success(txTraces.SelectMany(ParityTxTraceFromStore.FromTxTrace).ToArray());
         }
 
-        public ResultWrapper<ParityTxTraceFromStore[]> trace_get(Keccak txHash, int[] positions)
+        public ResultWrapper<ParityTxTraceFromStore[]> trace_get(Keccak txHash, long[] positions)
         {
-            throw new NotImplementedException();
+            ResultWrapper<ParityTxTraceFromStore[]> traceTransaction = trace_transaction(txHash);
+
+            List<ParityTxTraceFromStore> traces = new();
+            foreach (long t in positions)
+            {
+                if (traceTransaction.Data.Length > t+1)
+                {
+                    ParityTxTraceFromStore tr = traceTransaction.Data[t+1];
+                    traces.Add(tr);
+                }
+            }
+
+            return ResultWrapper<ParityTxTraceFromStore[]>.Success(traces.ToArray());
         }
 
         public ResultWrapper<ParityTxTraceFromStore[]> trace_transaction(Keccak txHash)
@@ -207,10 +220,10 @@ public ResultWrapper<ParityTxTraceFromStore[]> trace_transaction(Keccak txHash)
             {
                 return ResultWrapper<ParityTxTraceFromStore[]>.Fail(blockSearch);
             }
-
+        
             Block block = blockSearch.Object;
-
-            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace);
+            
+            IReadOnlyCollection<ParityLikeTxTrace> txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace);
             return ResultWrapper<ParityTxTraceFromStore[]>.Success(ParityTxTraceFromStore.FromTxTrace(txTrace));
         }
 
@@ -224,16 +237,17 @@ private IReadOnlyCollection<ParityLikeTxTrace> TraceBlock(Block block, ParityTra
 
             return listener.BuildResult();
         }
-
-        private ParityLikeTxTrace TraceTx(Block block, Keccak txHash, ParityTraceTypes traceTypes)
+        
+        private IReadOnlyCollection<ParityLikeTxTrace> TraceTx(Block block, Keccak txHash, ParityTraceTypes traceTypes)
         {
             using CancellationTokenSource cancellationTokenSource = new(_cancellationTokenTimeout);
             CancellationToken cancellationToken = cancellationTokenSource.Token;
 
             ParityLikeBlockTracer listener = new(txHash, traceTypes);
             _tracer.Trace(block, listener.WithCancellation(cancellationToken));
 
-            return listener.BuildResult().SingleOrDefault();
+            return listener.BuildResult();
         }
+
     }
 }