Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MEV v0.4 spec #3423

Merged
merged 23 commits into from
Nov 2, 2021
Merged

Add MEV v0.4 spec #3423

merged 23 commits into from
Nov 2, 2021

Conversation

avalonche
Copy link
Contributor

@avalonche avalonche commented Sep 16, 2021 •
edited by LukaszRozmej
Loading

Changes:

  • Implementing MEV 0.4 spec

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Need node run before merge

LukaszRozmej
LukaszRozmej reviewed Sep 21, 2021
View reviewed changes
src/Nethermind/Nethermind.Mev/Data/MevMegabundle.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
@avalonche avalonche force-pushed the mev-v0.4 branch 2 times, most recently from 4e36a97 to 9f88015 Compare September 23, 2021 09:11
LukaszRozmej
LukaszRozmej requested changes Sep 28, 2021
View reviewed changes
src/Nethermind/Nethermind.JsonRpc/ResultWrapper.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev.Test/MevRpcModuleTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Data/MevMegabundle.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/IMevConfig.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Data/BundleEventArgs.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Outdated Show resolved Hide resolved
kristofgazso
kristofgazso suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@kristofgazso kristofgazso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posdao tests succeeding, asking swaraj/mateusz to run the validator from this branch

src/Nethermind/Nethermind.Mev/IMevConfig.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevConfig.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/Source/BundlePool.cs Show resolved Hide resolved
@LukaszRozmej LukaszRozmej marked this pull request as ready for review October 15, 2021 09:59
LukaszRozmej
LukaszRozmej approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, some minor comments though

src/Nethermind/Nethermind.Mev/Data/MevBundle.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevConfig.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevRpcModule.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Mev/MevRpcModule.cs Outdated Show resolved Hide resolved
@LukaszRozmej LukaszRozmej mentioned this pull request Oct 26, 2021
Merged
@avalonche avalonche merged commit aaef50f into master Nov 2, 2021
@avalonche avalonche deleted the mev-v0.4 branch November 2, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofgazso kristofgazso kristofgazso approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avalonche @LukaszRozmej @kristofgazso