Eip 3607 #3280
Merged
Eip 3607 #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, requires bit more testing on actual chains |
# Conflicts: # src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs # src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.cs # src/Nethermind/Nethermind.Specs.Test/OverridableReleaseSpec.cs # src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainParameters.cs # src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecBasedSpecProvider.cs # src/Nethermind/Nethermind.Specs/Forks/00_Olympic.cs # src/Nethermind/Nethermind.Specs/Forks/01_Frontier.cs # src/Nethermind/Nethermind.Specs/Forks/02_Homestead.cs # src/Nethermind/Nethermind.Specs/Forks/03_Dao.cs # src/Nethermind/Nethermind.Specs/Forks/04_TangerineWhistle.cs # src/Nethermind/Nethermind.Specs/Forks/05_SpuriousDragon.cs # src/Nethermind/Nethermind.Specs/Forks/06_Byzantium.cs # src/Nethermind/Nethermind.Specs/Forks/07_Constantinople.cs # src/Nethermind/Nethermind.Specs/Forks/08_ConstantinopleFix.cs # src/Nethermind/Nethermind.Specs/Forks/09_Istanbul.cs # src/Nethermind/Nethermind.Specs/Forks/10_MuirGlacier.cs # src/Nethermind/Nethermind.Specs/Forks/11_Berlin.cs # src/Nethermind/Nethermind.Specs/Forks/12_London.cs # src/Nethermind/Nethermind.Specs/SystemTransactionReleaseSpec.cs
LukaszRozmej
approved these changes
Oct 15, 2021
MarekM25
reviewed
Oct 18, 2021
| @@ -112,6 +113,8 @@ internal class ChainSpecParamsJson | |||
|
|
|||
| public long? Eip3541Transition { get; set; } | |||
|
|
|||
| public long? Eip3607Transition { get; set; } = 0; | |||
There was a problem hiding this comment.
Is 0 okay here? We will enable EIP3607 on all networks that don't have it on genesis spec.
There was a problem hiding this comment.
yes, exactly we want it to be enabled by default. In Geth they just added it without EIP flag. As we support other set of networks I want it to be disabled by a setting, but want it to be enabled by default.
MarekM25
approved these changes
Oct 19, 2021
marcindsobczak
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit 3affda2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Changes that enable eip3607(https://eips.ethereum.org/EIPS/eip-3607).
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??