Send raw transaction fix #3037
Merged
Send raw transaction fix #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
May 4, 2021
| @@ -28,7 +28,10 @@ public enum RlpBehaviors | |||
| Storage = 4, | |||
| Eip658Receipts = 8, | |||
| AllowUnsigned = 16, | |||
| ForTreeRoot = 32, | |||
| All = AllowExtraData | ForSealing | Storage | Eip658Receipts | AllowUnsigned | ForTreeRoot | |||
| SkipTypedWrapping = 32, // introduced after typed transactions. In the network (devp2p) transaction has additional wrapping | |||
There was a problem hiding this comment.
Can we have 2 flags there with same value?
SkipTypedWrapping = 32
and
ForTreeRoot = 32
yes they are the same, but intention differs...
Not sure if good idea.
There was a problem hiding this comment.
Hmmmm. IMO the intention is the same. We're skipping byte array rlp for typed objects.
There was a problem hiding this comment.
Maybe name it:
ForTreeRoot
ForRpc/FromRpc ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for eth_sendRawTransaction
GETH, OE - don't use additional wrapping
Nethermind and probably Besu, TurboGeth - use additional wrapping.
I'm changing Nethermind to be like Geth/OE